Skip to content

fix/update-deps - #339

Merged
JosephSamirL merged 4 commits into
main-convertfrom
fix/update-deps
Nov 12, 2025
Merged

fix/update-deps#339
JosephSamirL merged 4 commits into
main-convertfrom
fix/update-deps

Conversation

@abbaseya

@abbaseya abbaseya commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

- chai: version 5.x breaks the unit tests
- tailwindcss: version 4.x breaks reactjs demo
@abbaseya
abbaseya requested a review from a team November 12, 2025 04:11
@abbaseya abbaseya self-assigned this Nov 12, 2025
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @abbaseya, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a significant maintenance task by updating numerous dependencies across the project's demo applications and internal SDK packages. The changes aim to bring all components up to date with the latest stable versions of their respective frameworks, libraries, and development tools. Additionally, specific adjustments were made to the Next.js demo to improve module compatibility and configuration, and SDK keys were refreshed in the RemixJS examples.

Highlights

  • Dependency Updates: All demo applications (NestJS, Next.js, Node.js, ReactJS, RemixJS client-side, RemixJS server-side) and core SDK packages have received comprehensive dependency updates, including major and minor version bumps for various libraries and development tools.
  • Next.js Demo Refactoring: The Next.js demo has been refactored to explicitly handle ESM imports for the SDK by introducing sdkWrapper.js and sdkWrapper.d.ts files, ensuring proper module resolution.
  • Next.js Configuration and TypeScript Enhancements: Updates to the Next.js demo include adjustments to next-env.d.ts for route types, simplification of next.config.mjs, changes in postcss.config.mjs for Tailwind CSS, and modifications to tsconfig.json for jsx and target settings, along with expanded include paths.
  • SDK Key Updates in RemixJS Demos: The sdkKey used in both RemixJS client-side and server-side demos has been updated to a new value.
  • ReactJS Build Script Modification: The start and build scripts in the ReactJS demo's package.json now include DISABLE_ESLINT_PLUGIN=true.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request focuses on updating dependencies across the entire monorepo, which is a significant undertaking involving major version bumps for key frameworks like React, Next.js, and NestJS. The changes also include necessary code adjustments, configuration updates, and workarounds to accommodate these new versions. My review has identified a couple of areas for improvement. Most notably, the React demo temporarily disables ESLint, which poses a code quality risk and should be addressed. Additionally, there's an opportunity to improve the maintainability of module imports in the Next.js demo.

Comment thread demo/reactjs/package.json
Comment thread demo/nextjs/src/convert/sdkWrapper.js
Comment thread demo/nextjs/src/convert/sdkWrapper.d.ts
@sonarqubecloud

Copy link
Copy Markdown

@JosephSamirL
JosephSamirL merged commit dd869e6 into main-convert Nov 12, 2025
5 checks passed
@JosephSamirL
JosephSamirL deleted the fix/update-deps branch November 12, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants